Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Unexpected floats when reading LI L2 LFL #2998

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ClementLaplace
Copy link
Contributor

Makes sure that the method apply_fill_value is not applied when _FillaValue is not into the attributes. It is fixing the bug mentioned there #2854 .

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (01237e2) to head (f06d07e).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2998      +/-   ##
==========================================
- Coverage   96.11%   96.11%   -0.01%     
==========================================
  Files         383      383              
  Lines       55673    55679       +6     
==========================================
+ Hits        53511    53514       +3     
- Misses       2162     2165       +3     
Flag Coverage Δ
behaviourtests 3.89% <0.00%> (-0.01%) ⬇️
unittests 96.20% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 12991062112

Details

  • 22 of 22 (100.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 96.217%

Files with Coverage Reduction New Missed Lines %
satpy/tests/reader_tests/_li_test_utils.py 1 98.55%
satpy/readers/li_base_nc.py 1 99.62%
satpy/tests/reader_tests/test_li_l2_nc.py 1 99.53%
Totals Coverage Status
Change from base Build 12905542942: -0.005%
Covered Lines: 53761
Relevant Lines: 55875

💛 - Coveralls

Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigations! I left some comments in the code.

I am also wondering if we still also need the fix for the float64 upcasting when multiplying with the scale_factor, as discussed in the issue...

satpy/readers/li_base_nc.py Outdated Show resolved Hide resolved
satpy/readers/li_base_nc.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_li_l2_nc.py Show resolved Hide resolved
…tests to check the dtype improve the mock datas
Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the extra more comprehensive tests! Just two things inline.

satpy/readers/li_base_nc.py Outdated Show resolved Hide resolved
satpy/readers/li_l2_nc.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/_li_test_utils.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_li_l2_nc.py Show resolved Hide resolved
Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ameraner ameraner added enhancement code enhancements, features, improvements component:readers bug labels Dec 5, 2024
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion inline.

Maybe we should start splitting the long test helpers to smaller chunks at some point?

I also restarted the one windows CI run.

satpy/readers/li_l2_nc.py Outdated Show resolved Hide resolved
@ClementLaplace ClementLaplace requested a review from pnuu January 27, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component:readers enhancement code enhancements, features, improvements
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

Unexpected floats when reading LI L2 LFL data
4 participants