-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Unexpected floats when reading LI L2 LFL #2998
base: main
Are you sure you want to change the base?
Conversation
…he _FillValue is not into the attributes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
==========================================
- Coverage 96.11% 96.11% -0.01%
==========================================
Files 383 383
Lines 55673 55679 +6
==========================================
+ Hits 53511 53514 +3
- Misses 2162 2165 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12991062112Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the investigations! I left some comments in the code.
I am also wondering if we still also need the fix for the float64
upcasting when multiplying with the scale_factor
, as discussed in the issue...
…tests to check the dtype improve the mock datas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix and the extra more comprehensive tests! Just two things inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion inline.
Maybe we should start splitting the long test helpers to smaller chunks at some point?
I also restarted the one windows CI run.
Makes sure that the method apply_fill_value is not applied when
_FillaValue
is not into the attributes. It is fixing the bug mentioned there #2854 .