New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for channel-specific SEVIRI calibration #2997

Open

sfinkens wants to merge 8 commits into pytroll:main from sfinkens:seviri-refactor-calibration

Open

Prepare for channel-specific SEVIRI calibration #2997

Remove duplicate warning

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Nov 22, 2024 in 1m 11s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.00 (9.27 -> 9.27)

Declining Code Health: 1 findings(s) 🚩
Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

Low Cohesion seviri_base.py

✅ Improving Code Health:

Excess Number of Function Arguments seviri_base.py: SEVIRICalibrationHandler.init

Annotations

Check warning on line 1 in satpy/readers/seviri_base.py

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Low Cohesion

The number of different responsibilities increases from 9 to 11, threshold = 4. Cohesion is calculated using the LCOM4 metric. Low cohesion means that the module/class has multiple unrelated responsibilities, doing too many things and breaking the Single Responsibility Principle.

Check notice on line 661 in satpy/readers/seviri_base.py

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Excess Number of Function Arguments

SEVIRICalibrationHandler.__init__ is no longer above the threshold for number of arguments

View more details on CodeScene Delta Analysis