Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assertRaises with pytest.raises #2624

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Nov 1, 2023

As the new ruff requires

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@mraspaud mraspaud requested a review from djhoese as a code owner November 1, 2023 13:53
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ace3999) 95.22% compared to head (e838867) 95.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2624      +/-   ##
==========================================
- Coverage   95.22%   95.21%   -0.02%     
==========================================
  Files         356      356              
  Lines       51547    51591      +44     
==========================================
+ Hits        49088    49120      +32     
- Misses       2459     2471      +12     
Flag Coverage Δ
behaviourtests 4.22% <0.00%> (-0.01%) ⬇️
unittests 95.83% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud mraspaud self-assigned this Nov 1, 2023
@mraspaud mraspaud added the cleanup Code cleanup but otherwise no change in functionality label Nov 1, 2023
@mraspaud mraspaud marked this pull request as draft November 1, 2023 14:08
@djhoese
Copy link
Member

djhoese commented Nov 1, 2023

Can you bump the version of ruff (or merge the pre-commit bot PR) to make sure that ruff is complaining about these?

@coveralls
Copy link

coveralls commented Nov 1, 2023

Pull Request Test Coverage Report for Build 6938256659

  • 117 of 117 (100.0%) changed or added relevant lines in 25 files are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 95.783%

Files with Coverage Reduction New Missed Lines %
satpy/tests/utils.py 2 93.36%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.16%
satpy/tests/reader_tests/utils.py 5 84.85%
Totals Coverage Status
Change from base Build 6907876977: -0.02%
Covered Lines: 49246
Relevant Lines: 51414

💛 - Coveralls

@mraspaud
Copy link
Member Author

mraspaud commented Nov 1, 2023

Can you bump the version of ruff (or merge the pre-commit bot PR) to make sure that ruff is complaining about these?

I will when I'm finished, otherwise I won't be able to commit smaller parts of the pr.

@djhoese
Copy link
Member

djhoese commented Nov 1, 2023

Shouldn't ruff only run locally on the files you modify/commit?

@mraspaud
Copy link
Member Author

mraspaud commented Nov 2, 2023

Ah, yes indeed, what was I thinking.

@mraspaud mraspaud marked this pull request as ready for review November 20, 2023 21:51
@djhoese djhoese merged commit 6a336fa into pytroll:main Nov 21, 2023
13 of 16 checks passed
@mraspaud mraspaud deleted the fix-ruff branch November 21, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants