Build wheels with numpy 2.0rc1 and fix scipy 1.13.0 compatibility #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the differences in packages during an upgrade that let me reproduce the test failures locally: |
|
Ok it is scipy 1.12.0 going to 1.13.0 that is causing the failures. Now to go down the rabbit hole... |
|
Ok caused by rewrites of the regular grid interpolator here: https://docs.scipy.org/doc/scipy/release/1.13.0-notes.html#scipy-interpolate-improvements |
djhoese
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 88.31% 88.34% +0.02%
==========================================
Files 21 21
Lines 1464 1467 +3
==========================================
+ Hits 1293 1296 +3
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mraspaud
approved these changes
Apr 12, 2024
Needs to be built with numpy 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numpy 2 api is stable now.
git diff origin/main **/*py | flake8 --diff