This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
NAT bug fix #676
Open
NAT bug fix #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove a duplicate operation. Line 1838 is doing the same thing. Earlier max_iter > 1 inference is broken internally. This fixes it, though we don't observe much performance gain for max_iter > 1. And the performance max_iter=1 doesn't change. Reviewed By: kahne Differential Revision: D19145640 fbshipit-source-id: d16ac37cfa2b77b5d25e2bd4d304c4847e71f6d1
|
This pull request was exported from Phabricator. Differential Revision: D19145640 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove a duplicate operation. Line 1838 is doing the same thing.
Earlier max_iter > 1 inference is broken internally. This fixes it, though we don't observe much performance gain for max_iter > 1. And the performance max_iter=1 doesn't change.
Reviewed By: kahne
Differential Revision: D19145640