[CI] Enable NEWLINE linter (#6162)

* Copy over newlines_linter.py from
https://github.com/pytorch/pytorch/blob/a94ec0a9a5ac91fcd9f69d6640ab0fe1efd068ae/tools/linter/adapters/newlines_linter.py
* Enable NEWLINE linter in CI
* Adds some files to the ignore list that probably shouldn't be changed
* Applies the linter `lintrunner -a --all-files --take NEWLINE`

We should move some of the adapter to some common place at some point,
or make it so that init will take them from pytorch automatically

.github/workflows/lint.yml

@@ -37,7 +37,7 @@ jobs:
       - name: Run lintrunner on all files - Linux
         run: |
           set +e
-          if ! lintrunner -v --force-color --all-files --tee-json=lint.json --take ACTIONLINT,MYPY,RUSTFMT,COPYRIGHT,LINTRUNNER_VERSION,UFMT; then
+          if ! lintrunner -v --force-color --all-files --tee-json=lint.json --take ACTIONLINT,MYPY,RUSTFMT,COPYRIGHT,LINTRUNNER_VERSION,UFMT,NEWLINE; then
               echo ""
               echo -e "\e[1m\e[36mYou can reproduce these results locally by using \`lintrunner -m main\`.\e[0m"
               exit 1

.github/workflows/tflint.yml

@@ -123,4 +123,3 @@ jobs:
     - name: "Run terraform validate terraform-aws-github-runner"
       working-directory: terraform-aws-github-runner
       run: terraform validate
-

.lintrunner.toml

@@ -111,6 +111,9 @@ exclude_patterns=[
     '**/*.ptl',
     '**/fixtures/**',
     '**/snapshots/**',
+    '.github/actions/setup-ssh/index.js',
+    'aws/lambda/log-classifier/data/**',
+    'tools/clang-tidy-checks/*-patches/**',
 ]
 command = [
     'python3',

terraform-aws-github-runner/modules/runner-binaries-syncer/variables.tf

@@ -55,4 +55,3 @@ variable "runner_allow_prerelease_binaries" {
   type        = bool
   default     = false
 }
-

tools/rockset_migration/README.md

@@ -1,2 +1 @@
 This folder contains tools/scripts used to help with migrating away from Rockset
-

tools/self-hosted-runner-utils/list-vpc-dependencies.sh

@@ -15,4 +15,3 @@ aws ec2 describe-vpn-gateways --region $region --filters 'Name=attachment.vpc-id
 aws ec2 describe-network-interfaces --region $region --filters 'Name=vpc-id,Values='$vpc | grep NetworkInterfaceId
 aws ec2 describe-carrier-gateways --region $region --filters Name=vpc-id,Values=$vpc | grep CarrierGatewayId
 aws ec2 describe-local-gateway-route-table-vpc-associations --region $region --filters Name=vpc-id,Values=$vpc | grep LocalGatewayRouteTableVpcAssociationId
-

torchci/clickhouse_queries/cost_job_per_gpu/query.sql

@@ -21,4 +21,3 @@ group by
     gpu
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/cost_job_per_owning_account/query.sql

@@ -21,4 +21,3 @@ group by
     owning_account
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/cost_job_per_platform/query.sql

@@ -21,4 +21,3 @@ group by
     platform
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/cost_job_per_provider/query.sql

@@ -21,4 +21,3 @@ group by
     rc.provider
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/cost_job_per_runner_type/query.sql

@@ -21,4 +21,3 @@ group by
     runner_type
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/cost_job_per_workflow_name/query.sql

@@ -21,4 +21,3 @@ group by
     workflow_name
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/duration_job_per_gpu/query.sql

@@ -21,4 +21,3 @@ group by
     gpu
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/duration_job_per_job_name/query.sql

@@ -21,4 +21,3 @@ group by
     job_name
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/duration_job_per_owning_account/query.sql

@@ -21,4 +21,3 @@ group by
     owning_account
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/duration_job_per_platform/query.sql

@@ -21,4 +21,3 @@ group by
     platform
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/duration_job_per_provider/query.sql

@@ -21,4 +21,3 @@ group by
     rc.provider
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/duration_job_per_repo/query.sql

@@ -21,4 +21,3 @@ group by
     repo
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/duration_job_per_runner_type/query.sql

@@ -21,4 +21,3 @@ group by
     runner_type
 order by
     granularity_bucket asc
-

torchci/clickhouse_queries/duration_job_per_workflow_name/query.sql

@@ -21,4 +21,3 @@ group by
     workflow_name
 order by
     granularity_bucket asc
-