Issue 942

[lxning]

Description

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

• [ X] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Feature/Issue validation/testing

Please describe the tests [UT/IT] that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

• Test A

• Test B

• UT/IT execution results
  test case1

• define max_request_size=10000 in config.properties

• run client: python torchserve_grpc_client.py infer vgg11_v2 ~/serve/examples/image_classifier/kitten.jpg

• result: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: gRPC message exceeds maximum size 10000: 110993

test case2

• define max_request_size=1000000 in config.properties

• run client: python torchserve_grpc_client.py infer vgg11_v2 ~/serve/examples/image_classifier/kitten.jpg

• result:
  {
  "tiger_cat": 0.5501413941383362,
  "tabby": 0.3231857717037201,
  "Egyptian_cat": 0.11440018564462662,
  "lynx": 0.006006317213177681,
  "tiger": 0.004394156392663717
  }

• Logs

Checklist:

• Have you added tests that prove your fix is effective or that this feature works?
• New and existing unit tests pass locally with these changes?
• Has code been commented, particularly in hard-to-understand areas?
• Have you made corresponding changes to the documentation?

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: 1f1ffbe
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-win
• Commit ID: 1f1ffbe
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: 1f1ffbe
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[maaquib]

LGTM. Can we also add a unit test for this

[lxning]

@maaquib The unit test for entire gRPC feature is missing. I filed a separate issue 980 for this task in next release.