Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to linux_job_v2 but tested this time #108

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Update to linux_job_v2 but tested this time #108

merged 2 commits into from
Jan 22, 2025

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jan 22, 2025 •
edited
Loading

Last time I didn't realize the workflow was failing. This time I know where to look (the Checks tab has a summary).

We also want to:

  • update the python version to a supported version (i'm choosing 3.13)
  • update the cuda version (not necessary but might as well not need to update this all the time)

atalman
atalman approved these changes Jan 22, 2025
View reviewed changes
Copy link

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@janeyx99 janeyx99 merged commit 8fe0de2 into master Jan 22, 2025
3 checks passed
@janeyx99 janeyx99 mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 zou3519 approved these changes

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janeyx99 @zou3519 @atalman @facebook-github-bot