Add additional overload signatures for shared methods to resolve pyre errors #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D64677349 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
force-pushed
the
export-D64677349
branch
from
18c525e to
2cb0060
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64677349 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
vivekmig
force-pushed
the
export-D64677349
branch
from
2cb0060 to
16eb31b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64677349 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 21, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
force-pushed
the
export-D64677349
branch
from
b40bc7b to
a7df6ff
Compare
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
|
This pull request was exported from Phabricator. Differential Revision: D64677349 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Oct 22, 2024
… errors (pytorch#1406) Summary: Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Reviewed By: csauper Differential Revision: D64677349
craymichael
pushed a commit
to craymichael/captum
that referenced
this pull request
Oct 23, 2024
… errors (pytorch#1406) Summary: Pull Request resolved: pytorch#1406 Add a few additional overload signatures to shared methods for resolving pyre errors Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8 Differential Revision: D64677349
|
This pull request has been merged in 0f7ea16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a few additional overload signatures to shared methods for resolving pyre errors
Also remove separate cases for typing Literal since the split was necessary due to previous support for Python < 3.8
Differential Revision: D64677349