-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 750: major updates to "Template Strings" based on community feedback #4062
Conversation
Update PEP 750 to use Template and Interpolation classes in a proposal part
Modified the `Interpolation` class definition, changing it from a `Protocol` to a regular class. Updated various instances in the PEP to reflect changes in syntax and terminology, replacing `tag function` with `template function` where appropriate.
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
This is after discussion amongst PEP authors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting up with me @davepeck! This seems in a good state to merge (I've left a comment on templatelib
on the thread, but it's non editorial.)
Do you have anything outstanding before merging? We should probably get this in before it hits 200 commits, and anything missed can be covered in a follow up.
Thank you again!
A
On the contrary, thank you for putting up with me and my zillion edits! :-)
Yes, at this point, I think we can merge. We'll need another turn of the crank for sure, but it's in a good place for now. |
Co-authored-by: Nice Zombies <[email protected]>
Thanks @davepeck! A |
…ack (python#4062) Co-authored-by: Koudai Aono <[email protected]> Co-authored-by: pauleveritt <[email protected]> Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Nice Zombies <[email protected]>
…ack (python#4062) Co-authored-by: Koudai Aono <[email protected]> Co-authored-by: pauleveritt <[email protected]> Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Nice Zombies <[email protected]>
PEP 123: Summary of changes
)This PR contains substantial updates to PEP 750 based on feedback from the broader Python community, including comments on the official PEP Discourse thread and in-person core team feedback at the recent Bellevue, WA, USA sprint.
It has been reviewed by:
Koudai Aono (@koxudaxi) and I were both added as co-authors.
Basic requirements (all PEP Types)
pep-NNNN.rst
), PR title (PEP 123: <Title of PEP>
) andPEP
headerAuthor
orSponsor
, and formally confirmed their approvalAuthor
,Status
(Draft
),Type
andCreated
headers filled out correctlyPEP-Delegate
,Topic
,Requires
andReplaces
headers completed if appropriate.github/CODEOWNERS
for the PEPStandards Track requirements
RationaleOpen IssuesPython-Version
set to valid (pre-beta) future Python version, if relevantAny project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such(not relevant?)Discussions-To
andPost-History
(the existing Discourse thread is found here )📚 Documentation preview 📚: https://pep-previews--4062.org.readthedocs.build/pep-0750/