-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 735: Draft 2 of Dependency Groups in pyproject.toml #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major changes are as follows: - remove support for path dependencies (!) - include a reference implementation - move 'use cases' into appendix - rephrase position vis-a-vis Poetry and PDM, and move details of those tools into an appendix - include more example data throughout - explicitly address the lack of standardization around "reserved names" for Dependency Groups in several places This revision should be shorter as well. Some redundant and wordy sections have been struck or rewritten.
brettcannon
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some clarifications to make along with fixing a reST CI failure.
Co-authored-by: Brett Cannon <[email protected]>
Better state that requirement lists contain `list[str|dict]`, and be consistent about calling TOML tables "tables" throughout, rather than "objects".
brettcannon
approved these changes
Dec 6, 2023
The content looks good, but unfortunately CI is still failing. |
It was snarled over some malformed TOML which I had written. It was a pretty small tweak to fix, but hard to spot by eye. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major changes are as follows:
This revision should be shorter as well. Some redundant and wordy sections have been struck or rewritten.
PEP 123: Summary of changes
)📚 Documentation preview 📚: https://pep-previews--3566.org.readthedocs.build/