PEP 725: version 2, addressing review comments on Discourse to date #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added Pillow example and changes to Cryptography and Scipy code from testing builds in https://github.com/rgommers/external-deps-build.
pradyunsg
approved these changes
Nov 25, 2023
|
Hi editors/reviewers, a friendly ping on this PR. It'd be great to get this merged so we can continue the discussion on Discourse. It should be good to go. |
hugovk
approved these changes
Dec 6, 2023
|
Thanks @hugovk |
jaimergp
reviewed
Feb 3, 2025
| @@ -363,19 +411,14 @@ SciPy 1.10: | |||
| "virtual:compiler/cpp", | |||
| "virtual:compiler/fortran", | |||
| "pkg:generic/ninja", | |||
| "pkg:generic/pkg-config", | |||
| ] | |||
| host-requires = [ | |||
| "virtual:interface/blas", | |||
| "virtual:interface/lapack", # >=3.7.1 (can't express version ranges with PURL yet) | |||
There was a problem hiding this comment.
This is now available as vers:, but not sure how the two specs play together. Via & union?
There was a problem hiding this comment.
Asked in package-url/purl-spec#66 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
pkg/pkg-devpackages, as well as how to treat needing Python development headers (xref say something aboutpython-develand how to treat that implicitly or explicitly rgommers/peps#10)Note that the contents were already reviewed by @pradyunsg and @msaharan over on rgommers#13, so this should be good to go.
📚 Documentation preview 📚: https://pep-previews--3546.org.readthedocs.build/