gh-97850: Update the deprecation warning of importlib.abc.Loader.load_module
#129855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
31 tasks
brettcannon
approved these changes
Feb 11, 2025
brettcannon
added
needs backport to 3.12
|
Thanks @tomasr8 for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 11, 2025
…er.load_module` (pythonGH-129855) (cherry picked from commit aa81a6f) Co-authored-by: Tomas R. <[email protected]>
|
GH-130013 is a backport of this pull request to the 3.13 branch. |
|
Sorry, @tomasr8 and @brettcannon, I could not cleanly backport this to |
|
I can look into the 3.12 backport later :) |
|
GH-130017 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation warning was added in 3.10 by #23469.
The warning currently states that the removal is planned for 3.12. I suggest we update it to say 3.15 which, following the 5 releases rule, is the earliest release in which the methods can be removed (whether or not we'll actually be able to do that is another question, but let's at least keep the warnings up to date).
Related discussion: #97850 (comment) , #97850 (comment)
📚 Documentation preview 📚: https://cpython-previews--129855.org.readthedocs.build/