Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Compose Spec schema and pre-commit hook #515

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add Compose Spec schema and pre-commit hook #515

merged 1 commit into from
Jan 14, 2025

Conversation

edgarrmondragon
Copy link
Contributor

Closes #513

sirosen
sirosen approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks for tackling this!

I will probably try a follow up change to try to remove the starting part of the pattern by getting rid of that start anchor. But this works, and that's good enough for me to merge it!

@sirosen sirosen merged commit 43475f7 into python-jsonschema:main Jan 14, 2025
23 checks passed
@edgarrmondragon edgarrmondragon deleted the compose-spec branch January 14, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirosen sirosen sirosen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New builtin schema: compose-spec
2 participants
@edgarrmondragon @sirosen