New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cheat.sh Command - Python cheatsheet #572

Merged

Xithrius merged 14 commits into python-discord:master from Shivansh-007:feature/cheat.sh

Feb 5, 2021

Contributor

Shivansh-007 commented Jan 31, 2021

Relevant Issues

Closes #570

Description

I had to overwrite the error result of the cht.sh as it was not according to our needs and the response always returned a 200 status code. And i also have defaulted the language to python so there is no way to use any other language rn.

Screenshots

Output too long

Error Embed

Normal Result

Additional Details

I thought i had commit my first commit, but i didn't, and hence the first commits' name is Fix Import Order.

Did you:

Join the Python Discord Community?
If dependencies have been added or updated, run pipenv lock?
Lint your code (pipenv run lint)?
Set the PR to allow edits from contributors?


          Fix import order

c60c847

ChrisLovering requested changes

View reviewed changes

Member

ChrisLovering left a comment

Only two things I think we should do for this PR. The could do's are optional if you feel like implementing them :)

bot/exts/evergreen/cheatsheet.py Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved


          Rename cog CheatSheet ; Change Embed code to a single constructor ; r…

a602361

…emove headers as chubin/cheat.sh#280 got merged ; improve error embed docstrings

Shivansh-007 requested a review from ChrisLovering

January 31, 2021 23:49

ChrisLovering requested changes

View reviewed changes

Member

ChrisLovering left a comment

Just 1 optional change. I've tested these changes locally and they work nicely! This should definitely help us out in the help channels, good job! :)

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

ChrisLovering approved these changes

View reviewed changes

Member

ChrisLovering left a comment

I meant to approve this, as the only change outstanding is optional.

Xithrius added area: backend level: 1 - intermediate type: feature status: needs review labels

Xithrius requested changes

View reviewed changes

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

Shivansh-007 and others added 4 commits

February 2, 2021 05:09


          Make use of constants

5c4cbbe


          Add override_in_channel deco


          Allow cht.sh command to be used in occupied help channels

3e884ea


          Merge branch 'master' into feature/cheat.sh

41c8c01

Contributor Author

Shivansh-007 commented Feb 2, 2021

@Xithrius @ChrisLovering Requested changes mentioned!

Shivansh-007 requested a review from Xithrius

February 2, 2021 00:38

HassanAbouelela reviewed

View reviewed changes

bot/constants.py Outdated Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

Shivansh-007 added 3 commits

February 2, 2021 06:16


          Improve category check code

b10b252


          everyone -> everyone_role and remove developers role

5190f5b


          Merge branch 'feature/cheat.sh' of https://github.com/Shivansh-007/si…

bfd1e28

…r-lancebot into feature/cheat.sh

Shivansh-007 requested a review from HassanAbouelela

February 2, 2021 00:49

Xithrius reviewed

View reviewed changes

Member

Xithrius left a comment

Looks good to me, except this one thing.

bot/exts/evergreen/cheatsheet.py Show resolved Hide resolved

HassanAbouelela removed their request for review

February 3, 2021 20:12

eklipse18 suggested changes

View reviewed changes

Contributor

eklipse18 left a comment •

edited

Loading

It looks nice overall, just a few minor changes could be done.

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

bot/exts/evergreen/cheatsheet.py Outdated Show resolved Hide resolved

Shivansh-007 added 3 commits

February 5, 2021 09:27


          Abrupt response, so make the bot type

3d30a1f


          Move repeated code to a single variable

f6cccfe


          Use brackets instead of / for multi line strings

95950b9


          Fix indentation

23c0b2f

Shivansh-007 requested a review from Xithrius

February 5, 2021 04:04

Xithrius approved these changes

View reviewed changes


          Merge branch 'master' into feature/cheat.sh

d0ef638

Xithrius merged commit c6353a8 into python-discord:master

Shivansh-007 deleted the feature/cheat.sh branch

February 7, 2021 11:12

Xithrius removed the status: needs review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend type: feature