-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: split tests for local / db [vol.2] #143
Conversation
Thank you! Sorry for the bother. |
no problem, it can happen 🐰 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 99.40% 99.60% +0.19%
==========================================
Files 5 5
Lines 508 508
Branches 88 88
==========================================
+ Hits 505 506 +1
+ Misses 2 1 -1
Partials 1 1 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pytest seems to be angry with the "NOT mongo". |
not sure I was using NOT without any issue, lets try it :) |
@shaypal5 seems some locals are still failing, mind have look, also feel free to push changes directly to this PR 🐿️ |
Ok, we're upping our game:
I wanted to require some checks to pass before merging, and when trying to select one from the list, it made me realize the current matricization of the the test job across different platforms make Github consider them as a separate checks, which is what has been annoying you in the PR conversation. The upside is that all such builds run in parallel. Please take this into consideration when suggesting an alternative; perhaps this can be collapsed somehow just for the conversation view's sake. Anyway, from now on, please work directly on dev branches of this repo and not your fork; you'll now be able to get your contributions tests directly against the live MongoDB server I've set up on the MongoDB Atlas platform on every push to your dev branches! :) |
Thank you and appreciate you granted me this privilege! |
Let's port it. |
Authored-by: Borda <https://github.com/Borda> , Shay just merged this. Co-authored-by: Jirka Borovec <[email protected]>
copy of #142, see: #142 (comment)
cc: @shaypal5