Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary uses of map() #1180

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Avoid unnecessary uses of map() #1180

merged 1 commit into from
Feb 5, 2025

Conversation

akx
Copy link
Member

@akx akx commented Jan 31, 2025

There were some rather legacy or "tricksy" uses of map(), which are probably better written out in other ways.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (5f117b2) to head (adfaf3c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1180   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          27       27           
  Lines        4689     4691    +2     
=======================================
+ Hits         4299     4301    +2     
  Misses        390      390           
Flag Coverage Δ
macos-14-3.10 90.72% <100.00%> (+<0.01%) ⬆️
macos-14-3.11 90.66% <100.00%> (+<0.01%) ⬆️
macos-14-3.12 90.87% <100.00%> (+<0.01%) ⬆️
macos-14-3.13 90.87% <100.00%> (+<0.01%) ⬆️
macos-14-3.8 90.59% <100.00%> (+<0.01%) ⬆️
macos-14-3.9 90.65% <100.00%> (+<0.01%) ⬆️
macos-14-pypy3.10 90.72% <100.00%> (+<0.01%) ⬆️
ubuntu-24.04-3.10 90.74% <100.00%> (+<0.01%) ⬆️
ubuntu-24.04-3.11 90.68% <100.00%> (+<0.01%) ⬆️
ubuntu-24.04-3.12 90.89% <100.00%> (+<0.01%) ⬆️
ubuntu-24.04-3.13 90.89% <100.00%> (+<0.01%) ⬆️
ubuntu-24.04-3.8 90.61% <100.00%> (+<0.01%) ⬆️
ubuntu-24.04-3.9 90.67% <100.00%> (+<0.01%) ⬆️
ubuntu-24.04-pypy3.10 90.74% <100.00%> (+<0.01%) ⬆️
windows-2022-3.10 90.73% <100.00%> (+<0.01%) ⬆️
windows-2022-3.11 90.67% <100.00%> (+<0.01%) ⬆️
windows-2022-3.12 90.88% <100.00%> (+<0.01%) ⬆️
windows-2022-3.13 90.88% <100.00%> (+<0.01%) ⬆️
windows-2022-3.8 90.71% <100.00%> (+<0.01%) ⬆️
windows-2022-3.9 90.66% <100.00%> (+<0.01%) ⬆️
windows-2022-pypy3.10 90.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx marked this pull request as ready for review February 1, 2025 14:35
@akx akx merged commit af0ff66 into master Feb 5, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants