chore: init KeeperMetrics with chain_id and provider_address, bump version #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…rsion Co-Authored-By: Jayant Krishnamurthy <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
jayantk
reviewed
Jan 31, 2025
apps/fortuna/src/keeper.rs
Outdated
| pub async fn new( | ||
| registry: Arc<RwLock<Registry>>, | ||
| chain_ids: Vec<String>, | ||
| provider_addresses: Vec<Address>, |
There was a problem hiding this comment.
please take a vec of tuples as a single argument: chain_ids_and_providers: Vec<(String, Address)>
jayantk
reviewed
Jan 31, 2025
apps/fortuna/src/keeper.rs
Outdated
| let mut writable_registry = registry.write().await; | ||
| let keeper_metrics = KeeperMetrics::default(); | ||
|
|
||
| // Initialize metrics for each chain_id and provider_address pair |
There was a problem hiding this comment.
move this loop to the end of the method
please also leave a comment giving instructions to someone adding a new metric. they need to register the metric and add a get_or_create call in the loop
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
jayantk
approved these changes
Jan 31, 2025
jayantk
deleted the
devin/1738353116-init-keeper-metrics-with-chain-params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize KeeperMetrics with chain_ids and provider_addresses
This PR modifies the KeeperMetrics::new method to accept Vec<chain_ids> and Vec<provider_addresses> as parameters, allowing proper initialization of metrics for all chains at once. This replaces the previous approach of initializing metrics one chain at a time.
Changes:
Link to Devin run: https://app.devin.ai/sessions/6db704545ae34e178633b42fefb736b5