remove provider from callback args

pyth-network · cctdaniel · Jan 24, 2025 · Jan 20, 2025 · Jan 20, 2025 · Jan 20, 2025
commit db135673ffcd1a47b778a29740e791156bbce715
diff --git a/target_chains/ethereum/contracts/contracts/pulse/IPulse.sol b/target_chains/ethereum/contracts/contracts/pulse/IPulse.sol
@@ -9,7 +9,6 @@ import "./PulseState.sol";
 interface IPulseConsumer {
     function pulseCallback(
         uint64 sequenceNumber,
-        address provider,
         PythStructs.PriceFeed[] memory priceFeeds
     ) external;
 }

diff --git a/target_chains/ethereum/contracts/contracts/pulse/Pulse.sol b/target_chains/ethereum/contracts/contracts/pulse/Pulse.sol
@@ -136,7 +136,7 @@ abstract contract Pulse is IPulse, PulseState {
         try
             IPulseConsumer(req.requester).pulseCallback{
                 gas: req.callbackGasLimit
-            }(sequenceNumber, msg.sender, priceFeeds)
+            }(sequenceNumber, priceFeeds)
         {
             // Callback succeeded
             emitPriceUpdate(sequenceNumber, priceIds, priceFeeds);

diff --git a/target_chains/ethereum/contracts/forge-test/Pulse.t.sol b/target_chains/ethereum/contracts/forge-test/Pulse.t.sol
@@ -13,16 +13,13 @@ import "../contracts/pulse/PulseErrors.sol";
 
 contract MockPulseConsumer is IPulseConsumer {
     uint64 public lastSequenceNumber;
-    address public lastProvider;
     PythStructs.PriceFeed[] private _lastPriceFeeds;
 
     function pulseCallback(
         uint64 sequenceNumber,
-        address provider,
         PythStructs.PriceFeed[] memory priceFeeds
     ) external override {
         lastSequenceNumber = sequenceNumber;
-        lastProvider = provider;
         for (uint i = 0; i < priceFeeds.length; i++) {
             _lastPriceFeeds.push(priceFeeds[i]);
         }
@@ -40,7 +37,6 @@ contract MockPulseConsumer is IPulseConsumer {
 contract FailingPulseConsumer is IPulseConsumer {
     function pulseCallback(
         uint64,
-        address,
         PythStructs.PriceFeed[] memory
     ) external pure override {
         revert("callback failed");
@@ -52,7 +48,6 @@ contract CustomErrorPulseConsumer is IPulseConsumer {
 
     function pulseCallback(
         uint64,
-        address,
         PythStructs.PriceFeed[] memory
     ) external pure override {
         revert CustomError("callback failed");
@@ -324,7 +319,6 @@ contract PulseTest is Test, PulseEvents {
 
         // Verify callback was executed
         assertEq(consumer.lastSequenceNumber(), sequenceNumber);
-        assertEq(consumer.lastProvider(), defaultProvider);
 
         // Compare price feeds array length
         PythStructs.PriceFeed[] memory lastFeeds = consumer.lastPriceFeeds();

diff --git a/apps/hermes/client/js/src/examples/HermesClient.ts b/apps/hermes/client/js/src/examples/HermesClient.ts

  eventSource.onmessage = (event: MessageEvent<string>) => {
    console.log("Received price update:", event.data);
    const _priceUpdate = JSON.parse(event.data) as PriceUpdate;
  };

  eventSource.onerror = (error: Event) => {
diff --git a/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts b/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts

 describe("Test parse accumulator update", () => {
  test("Happy path", async () => {
    const { vaa, updates } = parseAccumulatorUpdateData(
      Buffer.from(TEST_ACCUMULATOR_UPDATE_DATA, "base64")
    );

      ).updates.length
    ).toBe(3);

    const { vaa, updates } = parseAccumulatorUpdateData(
      sliceAccumulatorUpdateData(
        Buffer.from(TEST_ACCUMULATOR_UPDATE_DATA, "base64"),
        1,
diff --git a/price_service/client/js/src/__tests__/connection.e2e.test.ts b/price_service/client/js/src/__tests__/connection.e2e.test.ts
      let seenOutOfOrder = false;
      for (let i = 1; i < observedSlots.length; i++) {
        if (observedSlots[i] < observedSlots[i - 1]) {
          seenOutOfOrder = true;
        }
      }

diff --git a/contract_manager/scripts/deploy_evm_entropy_contracts.ts b/contract_manager/scripts/deploy_evm_entropy_contracts.ts
  getOrDeployWormholeContract,
  BaseDeployConfig,
 } from "./common";
 import Web3 from "web3";

 interface DeploymentConfig extends BaseDeployConfig {
  type: DeploymentType;
diff --git a/contract_manager/scripts/generate_governance_set_fee_payload.ts b/contract_manager/scripts/generate_governance_set_fee_payload.ts
 import yargs from "yargs";
 import { hideBin } from "yargs/helpers";
 import { DefaultStore } from "../src";
 import { Chain } from "../src/chains";

 const parser = yargs(hideBin(process.argv))
  .usage("Usage: $0 --chain <chain_id> --fee <fee> --exponent <exponent>")
diff --git a/contract_manager/scripts/latency_entropy_with_callback.ts b/contract_manager/scripts/latency_entropy_with_callback.ts
  findEntropyContract,
  findEvmChain,
 } from "./common";
 import Web3 from "web3";

 const parser = yargs(hideBin(process.argv))
  .usage(
diff --git a/contract_manager/scripts/load_test_entropy.ts b/contract_manager/scripts/load_test_entropy.ts
 import yargs from "yargs";
 import { hideBin } from "yargs/helpers";
 import {
  DefaultStore,
  EvmEntropyContract,
  PrivateKey,
  toPrivateKey,
 } from "../src";
 import {

	eventSource.onmessage = (event: MessageEvent<string>) => {
	console.log("Received price update:", event.data);
	const _priceUpdate = JSON.parse(event.data) as PriceUpdate;
Check warning on line 92 in apps/hermes/client/js/src/examples/HermesClient.ts GitHub Actions / test `'_priceUpdate' is assigned a value but never used`
	};

	eventSource.onerror = (error: Event) => {

	describe("Test parse accumulator update", () => {
	test("Happy path", async () => {
	const { vaa, updates } = parseAccumulatorUpdateData(
Check warning on line 14 in price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts GitHub Actions / test `'vaa' is assigned a value but never used`
	Buffer.from(TEST_ACCUMULATOR_UPDATE_DATA, "base64")
	);

	).updates.length
	).toBe(3);

	const { vaa, updates } = parseAccumulatorUpdateData(
Check warning on line 76 in price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts GitHub Actions / test `'vaa' is assigned a value but never used`
	sliceAccumulatorUpdateData(
	Buffer.from(TEST_ACCUMULATOR_UPDATE_DATA, "base64"),
	1,
	let seenOutOfOrder = false;
	for (let i = 1; i < observedSlots.length; i++) {
	if (observedSlots[i] < observedSlots[i - 1]) {
	seenOutOfOrder = true;
Check warning on line 224 in price_service/client/js/src/__tests__/connection.e2e.test.ts GitHub Actions / test `'seenOutOfOrder' is assigned a value but never used`
	}
	}
	getOrDeployWormholeContract,
	BaseDeployConfig,
	} from "./common";
	import Web3 from "web3";
Check warning on line 21 in contract_manager/scripts/deploy_evm_entropy_contracts.ts GitHub Actions / test `'Web3' is defined but never used`

	interface DeploymentConfig extends BaseDeployConfig {
	type: DeploymentType;
	import yargs from "yargs";
	import { hideBin } from "yargs/helpers";
	import { DefaultStore } from "../src";
	import { Chain } from "../src/chains";
Check warning on line 4 in contract_manager/scripts/generate_governance_set_fee_payload.ts GitHub Actions / test `'Chain' is defined but never used`

	const parser = yargs(hideBin(process.argv))
	.usage("Usage: $0 --chain <chain_id> --fee <fee> --exponent <exponent>")
	findEntropyContract,
	findEvmChain,
	} from "./common";
	import Web3 from "web3";
Check warning on line 14 in contract_manager/scripts/latency_entropy_with_callback.ts GitHub Actions / test `'Web3' is defined but never used`

	const parser = yargs(hideBin(process.argv))
	.usage(
	import yargs from "yargs";
	import { hideBin } from "yargs/helpers";
	import {
	DefaultStore,
Check warning on line 4 in contract_manager/scripts/load_test_entropy.ts GitHub Actions / test `'DefaultStore' is defined but never used`
	EvmEntropyContract,
Check warning on line 5 in contract_manager/scripts/load_test_entropy.ts GitHub Actions / test `'EvmEntropyContract' is defined but never used`
	PrivateKey,
Check warning on line 6 in contract_manager/scripts/load_test_entropy.ts GitHub Actions / test `'PrivateKey' is defined but never used`
	toPrivateKey,
	} from "../src";
	import {