feat(fortuna): Add a couple more config values #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
jayantk
commented
Jan 13, 2025
| /// The fee will be lowered if it is more profitable than specified here. | ||
| /// Must be larger than min_profit_pct. | ||
| pub max_profit_pct: u64, | ||
| /// The minimum value for this is -100. If set to < 0, it means the keeper may lose money on callbacks that use the full gas limit. | ||
| pub max_profit_pct: i64, |
There was a problem hiding this comment.
(In hindsight, I wish that i had specified these values as multipliers, so 0 would be the natural lower bound and you could just say "75" instead of "-25". That's how I did the other scalars and it would have been better here.
However, I'm choosing to support up to -100 now in order to maintain backward compatibility on the config format)
m30m
approved these changes
Jan 13, 2025
apps/fortuna/src/keeper.rs
Outdated
| chain_eth_config.target_profit_pct, | ||
| chain_eth_config.max_profit_pct, | ||
| // NOTE: unwrap() here so we panic early if someone configures these values below -100. | ||
| u64::try_from(100 + chain_eth_config.min_profit_pct).unwrap(), |
There was a problem hiding this comment.
maybe just switch to expect to give more context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two simple changes here