feat(pyth-lazer-protocol): remove TMP_EXPONENT #2221
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
| @@ -19,7 +19,7 @@ no-log-ix-name = [] | |||
| idl-build = ["anchor-lang/idl-build"] | |||
|
|
|||
| [dependencies] | |||
| pyth-lazer-protocol = { version = "0.1.2", path = "../../../../sdk/rust/protocol" } | |||
| pyth-lazer-protocol = "0.1.2" | |||
There was a problem hiding this comment.
Is there a reason we only use 0.1.2 for the contracts?
There was a problem hiding this comment.
i think at the time of the implementation this was the latest.
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "pyth-lazer-protocol" | |||
| version = "0.1.3" | |||
| version = "0.2.0" | |||
There was a problem hiding this comment.
When should we be doing a minor version upgrade like here? Not sure why we are going to 2.0 instead of 1.4.
There was a problem hiding this comment.
Changing the traits is considered a breaking change.
| pub fn to_f64(self, exponent: u32) -> anyhow::Result<f64> { | ||
| Ok(self.0.get() as f64 / 10i64.checked_pow(exponent).context("overflow")? as f64) | ||
| } | ||
|
|
||
| pub fn mul(self, rhs: Price, rhs_exponent: u32) -> anyhow::Result<Price> { | ||
| let left_value = i128::from(self.0.get()); | ||
| let right_value = i128::from(rhs.0.get()); | ||
|
|
||
| fn try_into(self) -> Result<f64, Self::Error> { | ||
| Ok(self.0.get() as f64 / 10i64.checked_pow(Self::TMP_EXPONENT).context("overflow")? as f64) | ||
| let value = left_value * right_value / 10i128.pow(rhs_exponent); | ||
| let value = value.try_into()?; | ||
| NonZeroI64::new(value) | ||
| .context("zero price is unsupported") | ||
| .map(Self) |
There was a problem hiding this comment.
any reason you removed the traits?
There was a problem hiding this comment.
With the need to pass an exponent to the mul and f64 cast functionalities, the traits are no longer suitable. So it has been changed to functions.
No description provided.