Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable priority fee multiplier #2195

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Add configurable priority fee multiplier to EVM chain configs

This change adds a new priority_fee_multiplier_pct parameter to the chain config for every EVM chain. This multiplier is applied to the max_priority_fee_per_gas parameter after the existing calculation logic.

  • Added priority_fee_multiplier_pct to EthereumConfig with default value of 100%
  • Modified EthProviderOracle to store and apply the multiplier
  • Updated gas oracle instantiation to pass the multiplier

Link to Devin run: https://app.devin.ai/sessions/1116e7617d284cf88ab32913e8671648

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:15am
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:15am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:15am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:15am
insights ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:15am

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

Co-Authored-By: Jayant Krishnamurthy <[email protected]>
@@ -166,6 +166,10 @@ pub struct EthereumConfig {
/// Maximum number of hashes to record in a request.
/// This should be set according to the maximum gas limit the provider supports for callbacks.
pub max_num_hashes: Option<u32>,

/// The percentage multiplier to apply to the priority fee (100 = no change, e.g. 150 = 150% of base fee)
#[serde(default = "default_priority_fee_multiplier_pct")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update sample config with this attribute as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants