feat(target_chains/ton): wormhole contract #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
cctdaniel
force-pushed
the
ton-wormhole
branch
from
6a0452a to
9daa9c1
Compare
cctdaniel
force-pushed
the
ton-wormhole
branch
from
9daa9c1 to
3674f60
Compare
cctdaniel
commented
Aug 20, 2024
| @@ -290,7 +290,7 @@ slice begin_parse(cell c) asm "CTOS"; | |||
| ;;; Preloads the first reference from the slice. | |||
| cell preload_ref(slice s) asm "PLDREF"; | |||
|
|
|||
| {- Functions below are commented because are implemented on compilator level for optimisation -} | |||
| {- Functions below are commented because are implemented on compilator level for optimisation -} | |||
There was a problem hiding this comment.
probably pre-commit
ali-bahjati
reviewed
Aug 21, 2024
There was a problem hiding this comment.
The code looks good but because the language is very low-level I like you to add much more documentations to the methods and logics so a less familiar reader can navigate through it easily.
Most of my comments are minor but I like to take another look after you've replied to/addressed them.
| "0x6FBEBC898F403E4773E95FEB15E80C9A99C8348D", | ||
| ]; | ||
|
|
||
| export function createGuardianSetUpgradeBytes( |
There was a problem hiding this comment.
isn't there any function in wormhole sdk to do it? we might have some ourselves too.
cctdaniel
force-pushed
the
ton-wormhole
branch
from
4a2cb1d to
f68bcb6
Compare
ali-bahjati
reviewed
Aug 22, 2024
ali-bahjati
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_encoded_upgrademain code and testparse_and_verify_wormhole_vmmain code and test