chore(target_chains/starknet): automate test data generation #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Riateche
force-pushed
the
starknet-automate-test-data
branch
2 times, most recently
from
cb28c5c to
16167c0
Compare
Riateche
changed the title
Riateche
force-pushed
the
starknet-automate-test-data
branch
from
16167c0 to
992f7be
Compare
|
These are great test VAA's and I'd call these golden tests even, am +1'ing but want to ask if you think we could rip these out and apply these to all the contracts rather than just this one? It's something we wanted a little while ago and can probably take advantage of for modifying other contracts (or introducing new ones). |
Reisen
approved these changes
May 20, 2024
|
Yes, I think we can use this implementation for other tests as well. Apart from calldata encoding, there is nothing specific to starknet in these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, instead of manually copying output from
test_vaastool to the cairo tests, we can simply run a command to automatically generatedata.cairothat contains all the generated data. I've also expanded comments for each item. Main test files (pyth.cairoandwormhole.cairo) should be more readable now. I've also added a CI check to ensure thatgenerate_test_data.rsanddata.cairostay in sync. There are no significant code changes, just a lot of moving code around.