Skip to content

Commit

Permalink
feat(pyth-lazer-protocol): remove TMP_EXPONENT
Browse files Browse the repository at this point in the history
  • Loading branch information
keyvankhademi committed Jan 2, 2025
1 parent 1b43f81 commit 800bff0
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 24 deletions.
2 changes: 1 addition & 1 deletion lazer/sdk/rust/protocol/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "pyth-lazer-protocol"
version = "0.1.3"
version = "0.2.0"
edition = "2021"
description = "Pyth Lazer SDK - protocol types."
license = "Apache-2.0"
Expand Down
35 changes: 12 additions & 23 deletions lazer/sdk/rust/protocol/src/router.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ impl TimestampUs {
pub struct Price(pub NonZeroI64);

impl Price {
// TODO: define exponent in price feed metadata instead
pub const TMP_EXPONENT: u32 = 8;

pub fn from_integer(value: i64, exponent: u32) -> anyhow::Result<Price> {
let coef = 10i64.checked_pow(exponent).context("overflow")?;
let value = value.checked_mul(coef).context("overflow")?;
Expand Down Expand Up @@ -77,13 +74,20 @@ impl Price {
pub fn into_inner(self) -> NonZeroI64 {
self.0
}
}

impl TryInto<f64> for Price {
type Error = anyhow::Error;
pub fn to_f64(self, exponent: u32) -> anyhow::Result<f64> {
Ok(self.0.get() as f64 / 10i64.checked_pow(exponent).context("overflow")? as f64)
}

pub fn mul(self, rhs: Price, rhs_exponent: u32) -> anyhow::Result<Price> {
let left_value = i128::from(self.0.get());
let right_value = i128::from(rhs.0.get());

fn try_into(self) -> Result<f64, Self::Error> {
Ok(self.0.get() as f64 / 10i64.checked_pow(Self::TMP_EXPONENT).context("overflow")? as f64)
let value = left_value * right_value / 10i128.pow(rhs_exponent);
let value = value.try_into()?;
NonZeroI64::new(value)
.context("zero price is unsupported")
.map(Self)
}
}

Expand Down Expand Up @@ -121,21 +125,6 @@ impl Div<i64> for Price {
}
}

impl Mul<Price> for Price {
type Output = Option<Price>;
fn mul(self, rhs: Price) -> Self::Output {
let left_value = i128::from(self.0.get());
let right_value = i128::from(rhs.0.get());

let value = left_value * right_value / 10i128.pow(Price::TMP_EXPONENT);
let value = match value.try_into() {
Ok(value) => value,
Err(_) => return None,
};
NonZeroI64::new(value).map(Self)
}
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub enum PriceFeedProperty {
Expand Down

0 comments on commit 800bff0

Please sign in to comment.