Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use publisher latest slot for staleness based pricing #91

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

ali-bahjati
Copy link
Collaborator

@ali-bahjati ali-bahjati commented Nov 16, 2023

This PR will use the latest slot of the publisher for staleness pricing. The issues that this solve is a publisher publishing for a not yet live feed and also a publisher publishing during market close hours. We can roll out this change to all the publishers without the market-close change and it should be similarly effective.

This change also includes changing the default variables for staleness gap and max paid price for priority fees.

  • staleness gap rationale: the rpc might be a bit behind by a few slots. Considering this delay and the exponential pricing this should change the unit price when the feed is really getting stale and doubling if it is still stale.
  • max paid price: the lowered value will result in almost 5m priority fee which is very high.

We will modify them later based on the performance of the publishers.

@ali-bahjati ali-bahjati force-pushed the ali-patch branch 2 times, most recently from 0f89067 to 7ed5c2a Compare November 16, 2023 17:20
src/agent/solana/exporter.rs Outdated Show resolved Hide resolved
@Reisen
Copy link
Contributor

Reisen commented Nov 16, 2023

Can you update the PR text with a little bit more clarity around the numbers, what you expect the burn-rate to be practically in the scenario this covers?

@ali-bahjati
Copy link
Collaborator Author

I added some comments on the code.

@ali-bahjati ali-bahjati merged commit 6e6ecbf into main Nov 16, 2023
2 checks passed
@ali-bahjati ali-bahjati deleted the ali-patch branch November 16, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants