feat: support batch publish #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riateche
force-pushed
the
batch-publish
branch
from
eaad36d to
a8e1056
Compare
Riateche
force-pushed
the
batch-publish
branch
from
a8e1056 to
30fb3eb
Compare
ali-bahjati
approved these changes
Sep 3, 2024
src/agent/state/exporter.rs
Outdated
| publish_program_key, | ||
| updates, | ||
| )?; | ||
| updates = unsupported_updates; |
There was a problem hiding this comment.
I think the fallback might fail because we also change the batch size, so maybe a simpler way can be just to crash? I think it highly depends on our upgrade process.
There was a problem hiding this comment.
Changed to return error on missing feed_index.
src/agent/state/exporter.rs
Outdated
| )?); | ||
| } | ||
| } | ||
| let mut data = vec![1]; |
There was a problem hiding this comment.
Please add a comment that this is the instruction id and the wire format in general.
There was a problem hiding this comment.
Now it imports instruction types from the program crate.
Cargo.toml
Outdated
| @@ -56,6 +56,8 @@ tracing-opentelemetry = "0.24.0" | |||
| opentelemetry = "0.23.0" | |||
| opentelemetry_sdk = { version = "0.23.0", features = ["rt-tokio"]} | |||
| opentelemetry-otlp = { version = "0.16.0" } | |||
| pyth-price-publisher = { git = "https://github.com/pyth-network/pyth-crosschain", branch = "add-publisher-program" } | |||
There was a problem hiding this comment.
let's publish this package too. also bump the agent version.
Riateche
force-pushed
the
batch-publish
branch
from
9335bcd to
801b902
Compare
ali-bahjati
approved these changes
Sep 9, 2024
Riateche
force-pushed
the
batch-publish
branch
from
a3593c3 to
7fea315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish_program_keyfield to the config