refactor(agent): extract oracle component/service #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
reviewed
Jun 20, 2024
|
|
||
| /// Capacities of the channels top-level components use to communicate | ||
| #[derive(Deserialize, Debug)] | ||
| pub struct ChannelCapacities { |
There was a problem hiding this comment.
might be good to mark the deprecated ones.
ali-bahjati
reviewed
Jun 20, 2024
src/agent/services/oracle.rs
Outdated
| state.clone(), | ||
| publisher_permissions_tx.clone(), | ||
| ) | ||
| .await; |
There was a problem hiding this comment.
maybe add some logs here?
ali-bahjati
reviewed
Jun 20, 2024
src/agent/services/oracle.rs
Outdated
|
|
||
| loop { | ||
| select! { | ||
| update = notifier.next() => handle_account_update(state.clone(), network, update).await, |
There was a problem hiding this comment.
how we handle websocket failures here? i don't see any logic to handle it. i think we had it in the past.
ali-bahjati
reviewed
Jun 20, 2024
src/agent/services/oracle.rs
Outdated
| }; | ||
| } | ||
| None => { | ||
| tracing::debug!("subscriber closed connection"); |
There was a problem hiding this comment.
back to my comment above, we need to reconnect when it happens.
ali-bahjati
reviewed
Jun 20, 2024
src/agent/solana.rs
Outdated
| /// | ||
| /// Behaviour: | ||
| /// - Spawns Oracle: (Obsolete, now Extracted to state/oracle.rs) | ||
| /// - Spawns a Subscriber: |
There was a problem hiding this comment.
subscriber is no more
ali-bahjati
reviewed
Jun 20, 2024
ali-bahjati
reviewed
Jun 20, 2024
Reisen
force-pushed
the
push-mxrwnmunwzxu
branch
from
98ee33a to
228d4e7
Compare
Reisen
force-pushed
the
push-mxrwnmunwzxu
branch
from
228d4e7 to
1724443
Compare
ali-bahjati
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.