refactor(agent): convert global store to an Api #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
reviewed
May 16, 2024
ali-bahjati
reviewed
May 16, 2024
ali-bahjati
reviewed
May 16, 2024
Comment on lines
+194
to
+183
| update_data(self, network, &update).await?; | ||
| update_metadata(self, &update).await?; |
There was a problem hiding this comment.
I don't know what your thoughts are on this. We could implement this on Store and here pass update_data(self.into(), network, ...)
ali-bahjati
approved these changes
May 16, 2024
There was a problem hiding this comment.
It seems very nice to me. I love seeing code getting simpler.
I don't love Adaptor name and it's position in the code. I think in the next PR we should change the name of the Adapter to a better name (like State) and move it out of pythd.
p.s: i think in the following PRs might be good to do mechanical moves as a separate commit so reviewing changes be easier. Github diff and difftastic couldn't put removed and added global.rs es together. I know it's a lot to ask while doing this kinds of refactors. So not important that much.
Reisen
force-pushed
the
push-xkzklrrorlrn
branch
2 times, most recently
from
2588b4e to
bf99855
Compare
ali-bahjati
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on from previous refactoring to change the global store from a running service to an API over the recently introduced
Adapterrefactor. While doing so, theglobal.rsmodule was moved and the code changed to reflect the new function calls that replace the previous channel based communication.This PR has a followup PR with the same changes to the
local.rsmodule. This PR is part of the following refactor: