Send publisher permissions using a watch channel to address heap growth #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes heap growth if Exporter::update_our_prices is not called as often as updates
| @@ -86,8 +86,7 @@ pub mod network { | |||
| logger: Logger, | |||
| ) -> Result<Vec<JoinHandle<()>>> { | |||
| // Publisher permissions updates between oracle and exporter | |||
| let (publisher_permissions_tx, publisher_permissions_rx) = | |||
| mpsc::channel(config.oracle.updates_channel_capacity); | |||
There was a problem hiding this comment.
I believe this was the only use of the updates_channel_capacity config. Let's remove the config as well if that's the case.
There was a problem hiding this comment.
updates_channel_capacity is still used for the "updates" channel (updates_tx,updates_rx).
ali-bahjati
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes heap growth if
Exporter::update_our_pricesis not called as often as updates.Running
agent --config config/config.sample.pythtest.tomlwould previously appear to "leak" memory quite quickly over time asExporter::update_our_priceswas not being called to drain the channel. The existing publisher permissions is bounded, but bounded at 10k would take a long time to fill and has a huge memory ceiling.The fix is straightforward as the receiver side only ever used the latest value sent anyway, replacing the mpsc bounded channel with a watch channel produces equivalent behaviour but with a drastically reduced memory ceiling as it holds a single clone of the
publisher_permissionsmap no matter the behaviour/frequency of the rx side.