Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #111

Merged
merged 1 commit into from
Mar 28, 2024
Merged

chore: update dependencies #111

merged 1 commit into from
Mar 28, 2024

Conversation

ali-bahjati
Copy link
Collaborator

@ali-bahjati ali-bahjati commented Mar 28, 2024

This change updates the agent dependencies to their most recent version. Please see the inline comments on the code changes due to the upgrades for an explanation.

@ali-bahjati ali-bahjati requested a review from Reisen March 28, 2024 18:37
if let Some(datetime) =
NaiveDateTime::from_timestamp_opt(local_data.timestamp, 0)
{
if let Some(datetime) = DateTime::from_timestamp(local_data.timestamp, 0) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a suggested change due to deprecation of the previous method, it returns a DateTime which has the same behaviour as the NaiveDateTime for formatting (because the inner NaiveDateTime is the same and Utc offset is 0).

global_metadata: Option<PriceAccountMetadata>,
local_data: Option<PriceInfo>,
global_data: Option<PriceEntry>,
_global_metadata: Option<PriceAccountMetadata>,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused variable

@@ -17,7 +17,7 @@ use {
},
toml_edit::{
value,
Document,
DocumentMut,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document was deprecated and DocumentMut was recommended as a workaround.

@ali-bahjati ali-bahjati merged commit 5d5a9d9 into main Mar 28, 2024
2 checks passed
@ali-bahjati ali-bahjati deleted the agent/update-dependencies branch March 28, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants