fix: remove unnecessary fresh price filtering #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes a check in the code that does not allow multiple updates within the same timestamp to passthrough. `last_info.timestamp` is always less than or equal to `info.timestamp`. So, this condition `last_info.timestamp < info.timestamp` filters newer updates in the same timestamp and essentially caps our publishing frequency to 1s. It was intended to work for Solana but the publishing frequency itself takes care of it. This change might result in increased Sol burn but the actions to reduce it should be reducing the frequency. Please note that in some filterings after, the same update prices are ignored so most of the fee savings should remain there.
jayantk
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes a check in the code that does not allow multiple updates within the same timestamp (second based) pass through.
last_info.timestampis always less than or equal toinfo.timestamp. So, this conditionlast_info.timestamp < info.timestampfilters newer updates in the same timestamp and essentially caps our publishing frequency to 1s. It was intended to work for Solana but the publishing frequency itself takes care of it. This change might result in increased Sol burn but the action to reduce it should be reducing the frequency. Please note that in some filterings after, the same update prices are ignored so most of the fee savings should remain there.