fix: disallow target account when creating position for integrity pool #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guibescos
reviewed
Aug 28, 2024
| @@ -82,6 +82,8 @@ pub enum ErrorCode { | |||
| MissingTargetAccount, | |||
| #[msg("The slash ratio should be between 0 and 1")] // 6038 | |||
| InvalidSlashRatio, | |||
| #[msg("Other")] //6039 | |||
| #[msg("The target account is not allowed for this operation")] // 6039 | |||
There was a problem hiding this comment.
Suggested change
| #[msg("The target account is not allowed for this operation")] // 6039 | |
| #[msg("The target account is only expected when dealing with the governance target")] // 6039 |
guibescos
reviewed
Aug 28, 2024
| @@ -189,6 +189,10 @@ pub mod staking { | |||
| } | |||
|
|
|||
| if let TargetWithParameters::IntegrityPool { .. } = target_with_parameters { | |||
| require!( | |||
There was a problem hiding this comment.
need to update close_position as well
guibescos
reviewed
Aug 29, 2024
| svm.send_transaction(create_position_tx), | ||
| ErrorCode::UnexpectedTargetAccount, | ||
| 0 | ||
| ); |
There was a problem hiding this comment.
this test is duplicated below
There was a problem hiding this comment.
the name was wrong, it is actually testing close position. Fixed.
The code changes refactor the `close_position` function to use the `close_position_ix` instruction instead of the `create_position_ix` instruction. This improves code clarity and consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.