feat: allow withdrawing without cleaning #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guibescos
changed the title
guibescos
commented
Aug 27, 2024
| if let Some(position) = self.read_position(i)? { | ||
| if position.target_with_parameters.get_target() == *target | ||
| && position.get_current_position(current_epoch, unlocking_duration)? | ||
| != PositionState::UNLOCKED |
There was a problem hiding this comment.
ignore unlocked here
guibescos
commented
Aug 27, 2024
| @@ -1385,6 +1409,13 @@ pub mod tests { | |||
| { | |||
| return false; | |||
| } | |||
|
|
|||
| if (target == &TargetWithParameters::Voting && curr_state == &PositionState::UNLOCKED) | |||
There was a problem hiding this comment.
this tests that slashing ignores unlocked governance positions, the new behavior
There was a problem hiding this comment.
do we need brackets here?
guibescos
commented
Aug 27, 2024
| @@ -81,6 +81,9 @@ describe("fills a stake account with positions", async () => { | |||
| ) { | |||
| await provider.sendAndConfirm(transaction, [], {}); | |||
| transaction = new Transaction(); | |||
| transaction.instructions.push( | |||
| ComputeBudgetProgram.setComputeUnitLimit({ units: 1_400_000 }) | |||
There was a problem hiding this comment.
this PR made me find this bug, previously we were just requesting compute units in the first tx
| @@ -351,7 +371,9 @@ impl<'a> DynamicPositionArray<'a> { | |||
| let current_state = | |||
| position.get_current_position(current_epoch, unlocking_duration)?; | |||
|
|
|||
| if position.target_with_parameters == TargetWithParameters::Voting { | |||
| if position.target_with_parameters == TargetWithParameters::Voting | |||
| && (current_state != PositionState::UNLOCKED) | |||
There was a problem hiding this comment.
do we need brackets here ()?
keyvankhademi
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can withdraw without cleaning.
For that I just need to update
validateto ignore Unlocked positions.We also need to update slashing since governance exposure no longer counts unlocked positions, so we ignore unlocked positions when we adjust positions in
slash_account