Accept transfer #310
Merged
Accept transfer #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guibescos
commented
Dec 20, 2023
| @@ -18,14 +18,14 @@ const RequestSplit: NextPage = () => { | |||
| const { connection } = useConnection() | |||
| const anchorWallet = useAnchorWallet() | |||
|
|
|||
| const [owner, setOwner] = useState<PublicKey>() | |||
| const [recipient, setRecipient] = useState<PublicKey>() | |||
There was a problem hiding this comment.
Rename owner to recipient
0xfirefist
reviewed
Dec 20, 2023
| break | ||
| } | ||
| } | ||
| } | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Maybe use useStakeConnection hook here and in request.tsx too?
0xfirefist
reviewed
Dec 20, 2023
| @@ -88,7 +88,7 @@ const RequestSplit: NextPage = () => { | |||
| ) | |||
There was a problem hiding this comment.
this comment refers to line 69
Can replace the useEffect hook with useStakeAccounts hook.
0xfirefist
reviewed
Dec 20, 2023
|
|
||
| const ApproveSplit: NextPage = () => { | ||
| const { connection } = useConnection() | ||
| const anchorWallet = useAnchorWallet() | ||
| const { publicKey, connected } = useWallet() | ||
| const [amount, setAmount] = useState<PythBalance>() |
There was a problem hiding this comment.
Can combine amount and recipient in an object. Since we are setting them always together.
Having an object result in one state update. Else, it will be multiple state updates. Imo is a good practice to have as less state update as possible.
0xfirefist
approved these changes
Dec 20, 2023
|
Sorry I really need this PR right now, let me fix comments later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor accept transfer
Add feature to be compatible with someone having multiple accounts