feat: Configuration option for setting default loop_scope for tests #1035
Conversation
Novakov
force-pushed
the
config-option-default-test-loop-scope
branch
4 times, most recently
from
cb06135 to
5272cc4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
+ Coverage 91.13% 91.27% +0.13%
==========================================
Files 2 2
Lines 564 573 +9
Branches 74 75 +1
==========================================
+ Hits 514 523 +9
Misses 30 30
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thank you! I really like how you changed _get_marked_loop_scope and how you used functions to keep the code readable.
Can you please add an entry to docs/reference/changelog.rst where you link to #793 ?
Assume that this PR bumps the minor version and set the date to UNRELEASED.
| @@ -0,0 +1,24 @@ | |||
| ======================================================= | |||
There was a problem hiding this comment.
It's nothing short of great that you even included a how-to guide for the new approach, thanks!
| @@ -9,6 +9,7 @@ How-To Guides | |||
| migrate_from_0_23 | |||
| change_fixture_loop | |||
| change_default_fixture_loop | |||
| change_default_test_loop | |||
There was a problem hiding this comment.
I think we can drop the "run_session_tests_in_same_loop" how-to guide. It's superseded by the configuration option. I cannot think of a use case where someone wants to use the pytest hook, instead of the config option.
Novakov
force-pushed
the
config-option-default-test-loop-scope
branch
2 times, most recently
from
787a67d to
aa2339d
Compare
New configuration option, asyncio_default_test_loop_scope, provides default value for loop_scope argument of asyncio marker. This can be used to use the same event loop in auto mode without need to use modifyitems hook. Test functions can still override loop_scope by using asyncio marker.
Novakov
force-pushed
the
config-option-default-test-loop-scope
branch
from
aa2339d to
6c3a941
Compare
|
Thanks for kind words. I've rebased this branch and applied modifications you requested. |
New configuration option,
asyncio_default_test_loop_scope, provides default value for loop_scope argument ofasynciomarker. This can be used to use the same event loop in auto mode without need to usemodifyitemshook.Test functions can still override
loop_scopeby usingasynciomarker.Implements #793