-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CirculantNormal
distribution.
#1988
Open
tillahoffmann
wants to merge
12
commits into
pyro-ppl:master
Choose a base branch
from
tillahoffmann:circulant
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+591
−7
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a00d035
Add `CirculantNormal` distribution.
tillahoffmann 76a04d5
Fix Jacobian of `RealFastFourierTransform`.
tillahoffmann a3fce16
Add transform to pack and unpack Fourier coefficients.
tillahoffmann 72804c5
Implement `CirculantNormal` using transformations.
tillahoffmann 881a5a7
Fix typo in skip reason for `test_generated_sample_distribution`.
tillahoffmann 394846c
Add `CirculantNormal` example notebook.
tillahoffmann c3e286f
Fix `noqa` comment.
tillahoffmann 19677dd
Reformat `circulant_gp` example notebook.
tillahoffmann 81c9bee
Fix keyword argument for `PackRealFastFourierCoefficientsTransform` t…
tillahoffmann 9f6dee2
Fix batch shape for mean, covariance_row, covariance_matrix.
tillahoffmann c6e5092
Add analytic KL divergence of diagonal `Normal` from `CirculantNormal`.
tillahoffmann 94c0409
Fix sign bug in `_PositiveDefiniteCirculantVector` validity check.
tillahoffmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm broadcasting to the full shape here instead of just promoting the shapes. That's to guarantee that
covariance_row
always has shapebatch_shape + event_shape
. If we only promoted shapes, we might end up with a shape(1, 1, n)
if the inputcovariance_row
has shape(n,)
but the inputloc
has shape(a, b, n)
.As an aside, this may also be relevant to
MultivariateNormal
distribution wherecovariance_matrix
may not have the right batch dimensions.