integrity: refine Accept header handling #17498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the
Accept
handling for this endpoint in the following ways:'identity'
marker to ensure an adequate fallback when the user doesn't explicitly specifyAccept
application/json
, although this could be removed from the changeset(NB: The main reason I added
application/json
is to ensure fallbacks/q-factor sorting works as expected.)I've also added a bunch of parametrized tests to ensure that we handle various combinations/orders/q-values correctly.
See #17084.