Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make environment column non-nullable for OIDC publishers #14372

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Make environment column non-nullable for OIDC publishers #14372

merged 6 commits into from
Aug 16, 2023

Conversation

di
Copy link
Member

@di di commented Aug 16, 2023

@di di requested a review from a team as a code owner August 16, 2023 20:48
miketheman
miketheman requested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the NULL quirks in the data migration, looks good.

warehouse/migrations/versions/a8ebe73ccaf2_make_githubpublisher_environment_non_.py Outdated Show resolved Hide resolved
@di di merged commit 15f2bed into pypi:main Aug 16, 2023
@di di deleted the non-nullable-environment branch August 16, 2023 21:12
@webknjaz
Copy link
Member

Possible regression: pypa/gh-action-pypi-publish#180

@di di mentioned this pull request Aug 17, 2023
Merged
@woodruffw woodruffw mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewdurbin ewdurbin ewdurbin approved these changes

@miketheman miketheman miketheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@di @webknjaz @miketheman @ewdurbin