Add GraalPy support #2832
Closed
Add GraalPy support #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_fast_get_system_executable doesn't have side effects, so it was merely asserting that the system python executable ends with a version
gaborbernat
requested changes
Jan 24, 2025
| @@ -44,7 +45,8 @@ def abs_path(v): | |||
|
|
|||
| # this is a tuple in earlier, struct later, unify to our own named tuple | |||
| self.version_info = VersionInfo(*sys.version_info) | |||
| self.architecture = 64 if sys.maxsize > 2**32 else 32 | |||
| # see https://github.com/pypa/packaging/pull/711 why we calculate architecture this way | |||
There was a problem hiding this comment.
Explain it here rather than link it.
| if IS_PYPY or (IS_WIN and sys.version_info[0:2] >= (3, 13)): # https://github.com/adamchainz/time-machine/issues/456 | ||
| if ( | ||
| IS_PYPY or IS_GRAALPY or (IS_WIN and sys.version_info[0:2] >= (3, 13)) | ||
| ): # https://github.com/adamchainz/time-machine/issues/456 |
There was a problem hiding this comment.
I think this can be now changed to just IS_PYPY or IS_GRAALPY as the issue has been fixed for Windows in the meantime.
|
seems it's stalled we can reopen when you restart work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for creating GraalPy virtualenvs and add GraalPy to the CI. The added code mostly mirrors PyPy3 implementation.
CC @timfel