Drop test dependency on path package
#4818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
changed the title
path package
Avasam
force-pushed
the
Drop-test-dependency-on-path-package
branch
from
03814ed to
3dc6443
Compare
Avasam
force-pushed
the
Drop-test-dependency-on-path-package
branch
from
3dc6443 to
9e5fc4b
Compare
|
After making this PR for something that looked like an unnecessary extra dependency. I went and looked at what exactly is I also noticed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As far as I can tell,
pathlib+jaraco.pathshould be sufficient, and it's only used in tests. There may be issues with vendored deps, let's see what the CI says.Closes
Pull Request Checklist
newsfragments/. (no public changes, tests only)(See documentation for details)