feat: support arbitary boto3 s3 config options in s3 backend #1697
Conversation
There was a problem hiding this comment.
Hi and thanks for this. I am sure it will be helpful for S3 bandersnatch users.
Is there any easy way we can use our minio unit/integration tests to make use of any of these config params to see at least one work? I feel this will help with future API changes etc. etc.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
==========================================
+ Coverage 79.69% 83.59% +3.90%
==========================================
Files 31 31
Lines 4324 4335 +11
Branches 780 782 +2
==========================================
+ Hits 3446 3624 +178
+ Misses 721 524 -197
- Partials 157 187 +30 ☔ View full report in Codecov by Sentry. |
|
@cooperlees -- added a test that uses minio. I also refactored |
There was a problem hiding this comment.
I don't have suggestions no how to make this any cleaner. So I am happy to merge if you are.
Though, when .s3keep objects are created, the configuration is not applied
Is there any open issue or is it worth opening an issue here to see if there is a bug or we're doing something wrong here?
If you are happy here I'll merge and if it benefits you cut a new release with the feature.
Thanks for the contribution! (I am no s3 guru tho)
| backend = s3.S3Storage(config=config_loader.config) | ||
| backend.initialize_plugin() | ||
|
|
||
| assert backend.configuration_parameters["ServerSideEncryption"] == "AES256" |
There was a problem hiding this comment.
Nice. I like that we have this - Long as AES256 isn't default :D
|
@joel-aws Happy for this to be merged? |
|
@cooperlees LGTM! |
No description provided.