Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pytest-asyncio from 0.21.1 to 0.23.4 #1625

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Bump pytest-asyncio from 0.21.1 to 0.23.4 #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d3034f
Bump pytest-asyncio from 0.21.1 to 0.23.2
dependabot[bot] Dec 11, 2023
8ed3218
Merge branch 'main' into dependabot/pip/pytest-asyncio-0.23.2
cooperlees Dec 11, 2023
e212d65
Merge branch 'main' into dependabot/pip/pytest-asyncio-0.23.2
cooperlees Dec 18, 2023
08ce08d
Set the mocked Master loop to current loop and supply a ThreadPool
cooperlees Jan 30, 2024
047a17f
Merge branch 'main' into dependabot/pip/pytest-asyncio-0.23.2
cooperlees Jan 30, 2024
acf14b4
Newer pytest-asyncio
cooperlees Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ freezegun==1.3.1
mypy==1.8.0
pre-commit==3.6.0
pytest==7.4.4
pytest-asyncio==0.21.1
pytest-asyncio==0.23.4
pytest-timeout==2.2.0
setuptools==69.0.3
tox==4.12.1
Expand Down
6 changes: 5 additions & 1 deletion src/bandersnatch/tests/test_master.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import asyncio
import concurrent.futures
from pathlib import Path
from tempfile import gettempdir
from unittest.mock import AsyncMock, patch
Expand Down Expand Up @@ -72,7 +74,9 @@ async def test_master_doesnt_raise_if_serial_equal(master: Master) -> None:
@pytest.mark.asyncio
async def test_master_url_fetch(master: Master) -> None:
fetch_path = Path(gettempdir()) / "unittest_url_fetch"
await master.url_fetch("https://unittest.org/asdf", fetch_path)
master.loop = asyncio.get_running_loop()
with concurrent.futures.ThreadPoolExecutor(max_workers=1) as thread_pool:
await master.url_fetch("https://unittest.org/asdf", fetch_path, thread_pool)
assert master.session.get.called


Expand Down