adding example for speed signs, adding exception if unit is not added…

… with a value for signals

scenariogeneration/xodr/signals_objects.py

@@ -22,7 +22,7 @@
     LaneType,
     Access,
 )
-from .exceptions import GeneralIssueInputArguments
+from .exceptions import GeneralIssueInputArguments, NotEnoughInputArguments
 from .utils import XodrBase
 
 
@@ -369,9 +369,12 @@ def get_attributes(self):
             retdict["countryRevision"] = str(self.countryRevision)
         if self.hOffset is not None:
             retdict["hOffset"] = str(self.hOffset)
-        # TODO check if value is supplied --> unit is mandatory in that case
         if self.value is not None:
             retdict["value"] = str(self.value)
+            if self.unit is None:
+                raise NotEnoughInputArguments(
+                    "If value is set for a signal, unit has to be added aswell"
+                )
             retdict["unit"] = str(self.unit)
         return retdict
 

tests/test_signals_objects.py

@@ -139,6 +139,9 @@ def test_signal():
         version_validation("t_road", road, wanted_schema="xodr")
         == ValidationResponse.OK
     )
+    with pytest.raises(xodr.NotEnoughInputArguments):
+        sig = xodr.Signal(100, 2, "se", "c", "31", value="10")
+        sig.get_attributes()
 
 
 def test_signal_reference():

tests/test_xml_validation.py

@@ -144,6 +144,7 @@ def test_OSC_1_2(tmpdir, python_file):
         "clothoid_generation",
         "adjustable_planview",
         "super_elevation_automation_example",
+        "road_with_speed_signs",
     ],
 )
 def test_ODR(tmpdir, python_file):