Add BetaGeoBetaBinomModel

[ColtAllen]

Description

Reopening #922 due to the force push.

The BG/BB model is for non-contractual purchase opportunities across discrete time periods; a good example would be sporting events.

Sampling is rather slow because NUTS defaults to compound sampling due to the discrete distributions used in this model. I recommend that #707 be merged to speed up performance.

A small addition to CLVBaseModel was required for the input validations, and the dev notebook is rather minimalist right now but will be expanded into a full how-to in a future PR. An inefficiency in distribution_new_customers that is shared by all CLV models was also identified and will be fixed in a separate PR.

Related Issue

• Closes Add BetaGeoBetaBinomModel #176
• Related to Replace scan in BetaGeoBetaBinom #707

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Modules affected

• MMM
• CLV

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

---

📚 Documentation preview 📚: https://pymc-marketing--1031.org.readthedocs.build/en/1031/

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[ColtAllen]

Is there a ruff version discrepancy between the CI and the pre-commit config? I'm not getting these errors when working locally and all dependencies are up to date.

[juanitorduz]

pre-commit.ci autofix

[juanitorduz]

Fixed by b3abdab using #1031 (comment)

@ColtAllen If you wanna add some changed make sure to pull first ;)

[juanitorduz]

@ColtAllen regarding

Sampling is rather slow because NUTS defaults to compound sampling due to the discrete distributions used in this model. I recommend that #707 be merged to speed up performance.

Do you see a speed-up with this model or all CLV models?

[juanitorduz]

Fantastic work @ColtAllen !

[juanitorduz]

@ColtAllen

This test is very slow:

6182.49s call     tests/clv/models/test_beta_geo_beta_binom.py::TestBetaGeoBetaBinomModel::test_model_convergence[mcmc-0.1]

Any ideas if we can make it a bit faster?

[ColtAllen]

Do you see a speed-up with this model or all CLV models?

#707 only impacts BetaGeoBetaBinomModel.

This test is very slow. Any ideas if we can make it a bit faster?

Merging #707 would make it about 3x faster. Only other way to speed it up would be to use a smaller fit dataset. There's another test here that is also rather slow, but addressing the TODOs will fix that.

[juanitorduz]

Ok! Then from my side we can merge this one and lets work on those to-dos 🙂