Move Surface towards compiling w/ SDL3 #3310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
force-pushed
the
surface-sdl3-a-bit
branch
from
a6a7412 to
23be387
Compare
Starbuck5
force-pushed
the
surface-sdl3-a-bit
branch
from
23be387 to
f02914d
Compare
MyreMylar
approved these changes
Jan 26, 2025
Starbuck5
commented
Jan 26, 2025
| @@ -775,7 +780,6 @@ surf_set_at(PyObject *self, PyObject *const *args, Py_ssize_t nargs) | |||
| { | |||
There was a problem hiding this comment.
If anyone is worried about performance impact I used set_at here as a test of overhead.
Used this script
import time
import pygame
pygame.init()
screen = pygame.Surface((300,300))
start = time.time()
for _ in range(1000000):
screen.set_at((4,35), 0x12345678)
print(time.time() - start)I saw no appreciable difference in runtime between main and this branch.
ankith26
reviewed
Jan 27, 2025
| @@ -823,6 +836,8 @@ surf_set_at(PyObject *self, PyObject *const *args, Py_ssize_t nargs) | |||
| break; | |||
| case 3: | |||
| byte_buf = (Uint8 *)(pixels + y * surf->pitch) + x * 3; | |||
| // Shouldn't this be able to happen without awareness of shifts? | |||
| // mapped color -> pixel and all. | |||
There was a problem hiding this comment.
I think this cannot be done because we don't have a Uint24 type, as most common architectures likely does not support 3-byte mov as a single instruction. So we have to break down the mapped color object back to 1-byte components for the assignment.
There was a problem hiding this comment.
That's a good theory. Other places in the codebase use memcpys to do it, perhaps the author of this section didn't think of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I ported a few modules and worked on a few others.
I first did everything with explicit SDL2 vs SDL3 code to observe patterns, then I made a few new compatibility macros to match what I saw.
This PR is those macros + the low hanging fruit in surface.c.
This is my take on a #3215 PR.