Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/improve _sdl2 stubs #3300

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix/improve _sdl2 stubs #3300

merged 1 commit into from
Jan 20, 2025
+12 −11

Conversation

ankith26
Copy link
Member

fixes #3298

@ankith26 ankith26 requested a review from a team as a code owner January 20, 2025 06:32
@ankith26
Copy link
Member Author

ankith26 commented Jan 20, 2025 •
edited
Loading

@zoldalma999 requesting your review as you authored the new controller module. I just noticed that the stubs for controller.pyi and controller_old.pyi are different, and the rumble stubs for controller_old.pyi were correct in this instance. controller_old.pyi also seems to have more stuff than controller.pyi.get_axis EDIT: Yes, this makes sense because I just checked out your PR and remembered that you intentionally skipped some old API in the port

aatle
aatle approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@aatle aatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes the failing local dev.py stubcheck errors.

@ankith26 ankith26 force-pushed the ankith26-sdl2-stubs branch from fc93bfc to c28a07b Compare January 20, 2025 07:59
zoldalma999
zoldalma999 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

damusss
damusss approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :>

As long as it keeps the fandom alive

  • aot ref

@damusss damusss added type hints Type hint checking related tasks _sdl2 pygame._sdl2 labels Jan 20, 2025
@damusss damusss added this to the 2.5.3 milestone Jan 20, 2025
@damusss damusss merged commit dd48270 into main Jan 20, 2025
25 checks passed
@ankith26 ankith26 deleted the ankith26-sdl2-stubs branch January 20, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatle aatle aatle approved these changes

@damusss damusss damusss approved these changes

@zoldalma999 zoldalma999 zoldalma999 approved these changes

Assignees
No one assigned
Labels
_sdl2 pygame._sdl2 type hints Type hint checking related tasks
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.

python dev.py stubs fails locally in stubcheck
4 participants
@ankith26 @zoldalma999 @damusss @aatle