Allow all color types mask.from_threshold and fix typing for PixelArray methods #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
reviewed
Oct 11, 2024
There was a problem hiding this comment.
As a matter of personal preference, I would like to have consistent handling within pixelarray for color values. As it is sort of documented at the module level, it would make sense to keep that behaviour everywhere in the module. Therefore I think this case is a "stubs should be fixed" thing
The mask change on the other hand, I am fine with.
|
@ankith26 I had actually forgot of this, now it should be ready |
ankith26
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand why slice-assignment of pixelarrays limits the allowed types, but this was likely not intended for the
replace()andextract()methods, as they were typehinted withColorValuebut don't currently allow all color values.This PR adds a C function specifically for those methods, making the typehints true.
The same thing applies to
mask.from_threshold.If you think they should not accept all color types, I can change the PR to change the typehints instead, of course.