add support for free-threaded wheels #955
Conversation
|
I believe we intentionally wanted to build against python.org Python's, but I absolutely do not remember why. Do you @reaperhulk ? |
|
Maybe related to the note about MacOS here and the difference in behavior on Python < 3.11? I'd need to figure out how to trigger a free-threaded install using the installer, but happy to switch it back if that was a load-bearing choice :) |
|
Probably macOS SDK compatibility, although I don’t recall if there was another reason. |
|
I couldn't figure out a way to include the necessary plist file into the actions workflow definition directly, so I added |
|
All the plist manipulation is cribbed from @colesbury's PR adding free-threading support to |
|
I think the test failure is unrelated |
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| # The tag to build or the tag received by the tag event | ||
| ref: ${{ github.event.inputs.version || github.ref }} | ||
| persist-credentials: false |
There was a problem hiding this comment.
Can we clone only the one file we need?
| - uses: dtolnay/rust-toolchain@a54c7afa936fefeb4456b2dd8068152669aa8203 | ||
| with: | ||
| toolchain: stable | ||
| # Add the arm64 target in addition to the native arch (x86_64) | ||
| target: aarch64-apple-darwin | ||
|
|
||
| - run: ${{ matrix.PYTHON.BIN_PATH }} -m venv venv | ||
| - run: python -m venv venv |
There was a problem hiding this comment.
Is this correct? Won't this use the system python, and not the one we just installed?
See this actions run on my fork.
Let me know if using
setup-pythonon MacOS is problematic for some reason.Fixes #913.