Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proof of concept: moving coordinate system to the geometry #4857

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

proof of concept: moving coordinate system to the geometry #4857

wants to merge 1 commit into from
+88 −120

Conversation

valentinsulzer
Copy link
Member

Description

Works for DFN, not broadly tested otherwise

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer valentinsulzer requested a review from a team as a code owner February 17, 2025 17:36
@valentinsulzer valentinsulzer mentioned this pull request Feb 17, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@valentinsulzer